Guidance requested on stalled PR adding pivoted QR decomposition

1

Hi all,

I am looking for guidance regarding a PR I opened that adds pivoted QR decomposition to ATen and torch.linalg:

PR: Add pivoted QR decomposition to ATen and torch.linalg by thkloss · Pull Request #170051 · pytorch/pytorch · GitHub

The PR includes tests and documentation and has been open for some time.
It is currently marked with the stale label and at risk of auto-closure due to missing reviewer bandwidth.

I realize that new features are typically discussed prior to merge requests.
I did not open a design discussion beforehand, but the feature was previously requested in:

Both are referenced in the PR.

At this point, I would appreciate guidance on:

  • Whether this functionality aligns with current PyTorch direction
  • Whether the implementation approach seems acceptable at a high level
  • Who would be the appropriate maintainer to review or sponsor this change

If the preferred path is to restructure this into a formal RFC or adjust the scope, I’m happy to do so.

Thanks for your time and guidance.

2

Hey!

Thank you for reaching out, sorry for the delay on this one, I’ve been trying to figure out the situation on our end.

Unfortunately our amazing maintainers for linear algebra questions Mario and Nik both moved companies and so have much less time to look at PyTorch issues.

The main challenge here is that we really don’t have that many people that are familiar with this kid of problems. I’ll continue searching and keep you updated!

Thanks for contributing!

3

Hi @albanD, thanks again for your earlier help and for offering to look for another reviewer.

I wanted to give a brief update on the PR. Since your last reply, I rebased it onto the current main branch again, resolved the merge conflicts, and addressed all the review feedback I received.

One of the reviewers indicated that they were happy for the PR to move forward and that, from their perspective, the previously raised issues had been addressed. However, there hasn’t been any further review activity for several weeks.

Do you have any suggestions on how to move this forward? In particular, would it make sense to involve another reviewer for the remaining review, or is there another step I should take?

I’d really appreciate any guidance. Thanks again!